Send connman mailing list submissions to
connman@lists.01.org
To subscribe or unsubscribe via email, send a message with subject or
body 'help' to
connman-requ...@lists.01.org
You can reach the person managing the list at
connman-ow...@lists.01.org
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. RE: [PATCH] timeserver: Fix time update manual->auto at startup
(VAUTRIN Emmanuel (Canal Plus Prestataire))
2. Re: [PATCH 2/2] wispr: Update service state on connection loss
(Daniel Wagner)
3. Re: [PATCH] timeserver: Fix time update manual->auto at startup
(Daniel Wagner)
4. RE: [PATCH] timeserver: Fix time update manual->auto at startup
(VAUTRIN Emmanuel (Canal Plus Prestataire))
----------------------------------------------------------------------
Date: Fri, 5 Feb 2021 08:59:43 +0000
From: "VAUTRIN Emmanuel (Canal Plus Prestataire)"
<emmanuel.vaut...@cpexterne.org>
Subject: RE: [PATCH] timeserver: Fix time update manual->auto at
startup
To: Daniel Wagner <w...@monom.org>
Cc: "connman@lists.01.org" <connman@lists.01.org>
Message-ID: <pr1pr02mb47944cd220a2b21c6df71b8193...@pr1pr02mb4794.eur
prd02.prod.outlook.com>
Content-Type: multipart/alternative; boundary="_000_PR1PR02MB47944C
D220A2B21C6DF71B8193B29PR1PR02MB4794eurp_"
--_000_PR1PR02MB47944CD220A2B21C6DF71B8193B29PR1PR02MB4794eurp_
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Daniel,
I also have thought about this solution, but honestly, I doubt about that o=
ne, as there is/are "service =3D=3D ts_service" check(s) in the code. Sett=
ing back to NULL will fail in this/these case(s).
B.R.
Emmanuel
________________________________
De : Daniel Wagner <w...@monom.org>
Envoy=E9 : vendredi 5 f=E9vrier 2021 09:53
=C0 : VAUTRIN Emmanuel (Canal Plus Prestataire) <Emmanuel.VAUTRIN@cpexterne=
.org>
Cc : connman@lists.01.org <connman@lists.01.org>
Objet : Re: [PATCH] timeserver: Fix time update manual->auto at startup
Hi Emmanuel,
On Wed, Feb 03, 2021 at 03:36:42PM +0000, VAUTRIN Emmanuel (Canal Plus Pres=
tataire) wrote:
> When resetting the time synchronization, always set the associated
> service, even when the timeserver list is empty, to enable future
> synchronization, when switching time update from manual to auto.
Thanks for the explanation. In this case I think we should do just
if (!timeservers_list) {
DBG("No timeservers set.");
ts_service =3D NULL;
return;
}
Wouldn't this be enough?
Thanks,
Daniel
--_000_PR1PR02MB47944CD220A2B21C6DF71B8193B29PR1PR02MB4794eurp_
Content-Type: text/html; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
<html>
<head>
<meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Diso-8859-=
1">
<style type=3D"text/css" style=3D"display:none;"> P {margin-top:0;margin-bo=
ttom:0;} </style>
</head>
<body dir=3D"ltr">
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0);">
Daniel,</div>
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0);">
I also have thought about this solution, but honestly, I doubt about that o=
ne, as there is/are "service =3D=3D ts_service" check(s) in=
the code. Setting back to NULL will fail in this/these case(s).</div>
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0);">
B.R.</div>
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0);">
Emmanuel<br>
</div>
<div id=3D"appendonsend"></div>
<div style=3D"font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12p=
t; color:rgb(0,0,0)">
<br>
</div>
<hr tabindex=3D"-1" style=3D"display:inline-block; width:98%">
<div id=3D"divRplyFwdMsg" dir=3D"ltr"><font style=3D"font-size:11pt" face=
=3D"Calibri, sans-serif" color=3D"#000000"><b>De :</b> Daniel Wagner <wa=
g...@monom.org><br>
<b>Envoy=E9 :</b> vendredi 5 f=E9vrier 2021 09:53<br>
<b>=C0 :</b> VAUTRIN Emmanuel (Canal Plus Prestataire) <Emmanuel.VAUTRIN=
@cpexterne.org><br>
<b>Cc :</b> connman@lists.01.org <connman@lists.01.org><br>
<b>Objet :</b> Re: [PATCH] timeserver: Fix time update manual->auto at s=
tartup</font>
<div> </div>
</div>
<div class=3D"BodyFragment"><font size=3D"2"><span style=3D"font-size:11pt"=
>
<div class=3D"PlainText">Hi Emmanuel,<br>
<br>
On Wed, Feb 03, 2021 at 03:36:42PM +0000, VAUTRIN Emmanuel (Canal Plus Pres=
tataire) wrote:<br>
> When resetting the time synchronization, always set the associated<br>
> service, even when the timeserver list is empty, to enable future<br>
> synchronization, when switching time update from manual to auto.<br>
<br>
Thanks for the explanation. In this case I think we should do just<br>
<br>
if (!timeservers_list) {<br>
&nb=
sp; DBG("No timeservers set.");<br>
&nb=
sp; ts_service =3D NULL;<br>
&nb=
sp; return;<br>
}<br>
<br>
Wouldn't this be enough?<br>
<br>
Thanks,<br>
Daniel<br>
</div>
</span></font></div>
</body>
</html>
--_000_PR1PR02MB47944CD220A2B21C6DF71B8193B29PR1PR02MB4794eurp_--
------------------------------
Date: Fri, 5 Feb 2021 10:05:53 +0100
From: Daniel Wagner <w...@monom.org>
Subject: Re: [PATCH 2/2] wispr: Update service state on connection
loss
To: "VAUTRIN Emmanuel (Canal Plus Prestataire)"
<emmanuel.vaut...@cpexterne.org>
Cc: "connman@lists.01.org" <connman@lists.01.org>
Message-ID: <20210205090553.6h5tazauboovz...@beryllium.lan>
Content-Type: text/plain; charset=us-ascii
Hi Emmanuel,
On Fri, Feb 05, 2021 at 08:37:28AM +0000, VAUTRIN Emmanuel (Canal Plus
Prestataire) wrote:
> Hi Daniel,
>
> > If the connection is dropped ConnMan should go through the state
> > transition from read/online to failure/error to idle. Then the normal
> > reconnect algorithm should kick in. Or what do you mean with connection
> > loss?
> My meaning was no more Internet connection, connected but offline, instead of
> disconnected.
Okay, this is unfortunately a touchy topic. So we forgot to add the
state transition from Online to Ready in ('Service states' in
doc/overview-api.txt). You are not the first who wants to have this
added but we have users who do not want the API to change as it might
result in a lot of troubles in their UI as it does not expect this
transition. Also ConnMan might not be able to handle it correctly:
https://lists.syncevolution.org/hyperkitty/list/connman@lists.01.org/thread/FPAYW7TKIXFF5KOZL7U4RW72XCMUVZLZ/
https://lists.ofono.org/hyperkitty/list/connman@lists.01.org/thread/C4BFH7RACCV3354UW64I5I7U4YPLGILT/
I am not against such a feature but it really needs to opt-in and it
needs a lot of testing.
Thanks,
Daniel
------------------------------
Date: Fri, 5 Feb 2021 10:10:22 +0100
From: Daniel Wagner <w...@monom.org>
Subject: Re: [PATCH] timeserver: Fix time update manual->auto at
startup
To: "VAUTRIN Emmanuel (Canal Plus Prestataire)"
<emmanuel.vaut...@cpexterne.org>
Cc: "connman@lists.01.org" <connman@lists.01.org>
Message-ID: <20210205091022.5qfjnczyv3yg6...@beryllium.lan>
Content-Type: text/plain; charset=us-ascii
On Fri, Feb 05, 2021 at 08:59:43AM +0000, VAUTRIN Emmanuel (Canal Plus
Prestataire) wrote:
> I also have thought about this solution, but honestly, I doubt about
> that one, as there is/are "service == ts_service" check(s) in the
> code. Setting back to NULL will fail in this/these case(s).
Well, the ts sync engine is stopped at this point. ts_service is NULL on
the initial startup. So why should 'service == ts_service' checks not
behave correctly? ts_service = NULL is looks correct. If you think the
checks are not correct then we need to review them now. Adding
'ts_service = service' before the timerservers_list check looks bogus
and is papering over a problem if 'ts_servce = NULL;' doesn't work.
------------------------------
Date: Fri, 5 Feb 2021 09:25:51 +0000
From: "VAUTRIN Emmanuel (Canal Plus Prestataire)"
<emmanuel.vaut...@cpexterne.org>
Subject: RE: [PATCH] timeserver: Fix time update manual->auto at
startup
To: Daniel Wagner <w...@monom.org>
Cc: "connman@lists.01.org" <connman@lists.01.org>
Message-ID: <pr1pr02mb4794d5f94ef3f614eb8e92f193...@pr1pr02mb4794.eur
prd02.prod.outlook.com>
Content-Type: text/plain; charset="iso-8859-1"
> Well, the ts sync engine is stopped at this point. ts_service is NULL on
> the initial startup. So why should 'service == ts_service' checks not
> behave correctly? ts_service = NULL is looks correct. If you think the
> checks are not correct then we need to review them now. Adding
> 'ts_service = service' before the timerservers_list check looks bogus
> and is papering over a problem if 'ts_servce = NULL;' doesn't work.
In fact, it is the contrary, my goal was not to change the checks.
If I follow this proposal:
1. Starting with a current service and a not empty config timeserver list,
but in manual mode, we have timerservers_list == NULL
-> ts_service = NULL
2. Switching to auto mode, we have ts_service == NULL
-> no synchro in __connman_timeserver_sync()
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list -- connman@lists.01.org
To unsubscribe send an email to connman-le...@lists.01.org
------------------------------
End of connman Digest, Vol 64, Issue 5
**************************************
