Send connman mailing list submissions to
connman@lists.01.org
To subscribe or unsubscribe via email, send a message with subject or
body 'help' to
connman-requ...@lists.01.org
You can reach the person managing the list at
connman-ow...@lists.01.org
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. [PATCH] iwd: Fix typo in error message when stopping AccessPoint mode
(Jonathan Liu)
2. [PATCH] iwd: Fix disabling tethering not working for brcmfmac
(Jonathan Liu)
3. Re: [PATCH] iwd: Fix disabling tethering not working for brcmfmac
(Jonathan Liu)
----------------------------------------------------------------------
Date: Mon, 15 Mar 2021 17:00:01 +1100
From: Jonathan Liu <net...@gmail.com>
Subject: [PATCH] iwd: Fix typo in error message when stopping
AccessPoint mode
To: connman@lists.01.org
Cc: Jonathan Liu <net...@gmail.com>
Message-ID: <20210315060001.1244609-1-net...@gmail.com>
The error text indicates that it could not start AccessPoint mode when
it is actually trying to stop AccessPoint mode.
Fixes: 648ed549f0ac ("iwd: Add support for tethering")
---
plugins/iwd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/plugins/iwd.c b/plugins/iwd.c
index 21f646c5..0a25fabf 100644
--- a/plugins/iwd.c
+++ b/plugins/iwd.c
@@ -766,7 +766,7 @@ static void tech_disable_tethering_cb(const DBusError
*error, void *user_data)
if (!g_dbus_proxy_method_call(iwdap->proxy, "Stop",
NULL, tech_ap_stop_cb, cbd, NULL)) {
- connman_warn("iwd ap %s could not start AccessPoint mode: %s",
+ connman_warn("iwd ap %s could not stop AccessPoint mode: %s",
cbd->path, error->message);
goto out;
}
--
2.30.1
------------------------------
Date: Mon, 15 Mar 2021 17:00:19 +1100
From: Jonathan Liu <net...@gmail.com>
Subject: [PATCH] iwd: Fix disabling tethering not working for brcmfmac
To: connman@lists.01.org
Cc: Jonathan Liu <net...@gmail.com>
Message-ID: <20210315060019.1244803-1-net...@gmail.com>
For Broadcom BCM4356 chipset with brcmfmac driver, changing from AP mode
to station mode returns -EBUSY if the wireless interface is a member of
a bridge.
To resolve the issue, the wireless interface is removed from the tether
bridge before changing the mode rather than after.
Fixes: 648ed549f0ac ("iwd: Add support for tethering")
---
plugins/iwd.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/plugins/iwd.c b/plugins/iwd.c
index 0a25fabf..02f358ef 100644
--- a/plugins/iwd.c
+++ b/plugins/iwd.c
@@ -758,10 +758,6 @@ static void tech_disable_tethering_cb(const DBusError
*error, void *user_data)
iwdap->index = -1;
iwdap->bridge = NULL;
iwdap->tech = NULL;
-
- if (!connman_inet_remove_from_bridge(cbd->index, cbd->bridge))
- goto out;
-
connman_technology_tethering_notify(cbd->tech, false);
if (!g_dbus_proxy_method_call(iwdap->proxy, "Stop",
@@ -790,6 +786,9 @@ static int cm_change_tethering(struct iwd_device *iwdd,
if (index < 0)
return -ENODEV;
+ if (!enabled && !connman_inet_remove_from_bridge(index, bridge))
+ return -EIO;
+
cbd = g_new(struct tech_cb_data, 1);
cbd->iwdd = iwdd;
cbd->path = g_strdup(iwdd->path);
--
2.30.1
------------------------------
Date: Mon, 15 Mar 2021 17:59:23 +1100
From: Jonathan Liu <net...@gmail.com>
Subject: Re: [PATCH] iwd: Fix disabling tethering not working for
brcmfmac
To: connman@lists.01.org
Message-ID:
<CANwerB3MEdMh=azju1ssuonikj8jitv0vg0adisy2+6j_jf...@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Hi,
It seems there are issues with this patch. Will follow up with a V2.
Regards,
Jonathan
On Mon, 15 Mar 2021 at 17:00, Jonathan Liu <net...@gmail.com> wrote:
>
> For Broadcom BCM4356 chipset with brcmfmac driver, changing from AP mode
> to station mode returns -EBUSY if the wireless interface is a member of
> a bridge.
>
> To resolve the issue, the wireless interface is removed from the tether
> bridge before changing the mode rather than after.
>
> Fixes: 648ed549f0ac ("iwd: Add support for tethering")
> ---
> plugins/iwd.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/plugins/iwd.c b/plugins/iwd.c
> index 0a25fabf..02f358ef 100644
> --- a/plugins/iwd.c
> +++ b/plugins/iwd.c
> @@ -758,10 +758,6 @@ static void tech_disable_tethering_cb(const DBusError
> *error, void *user_data)
> iwdap->index = -1;
> iwdap->bridge = NULL;
> iwdap->tech = NULL;
> -
> - if (!connman_inet_remove_from_bridge(cbd->index, cbd->bridge))
> - goto out;
> -
> connman_technology_tethering_notify(cbd->tech, false);
>
> if (!g_dbus_proxy_method_call(iwdap->proxy, "Stop",
> @@ -790,6 +786,9 @@ static int cm_change_tethering(struct iwd_device *iwdd,
> if (index < 0)
> return -ENODEV;
>
> + if (!enabled && !connman_inet_remove_from_bridge(index, bridge))
> + return -EIO;
> +
> cbd = g_new(struct tech_cb_data, 1);
> cbd->iwdd = iwdd;
> cbd->path = g_strdup(iwdd->path);
> --
> 2.30.1
>
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list -- connman@lists.01.org
To unsubscribe send an email to connman-le...@lists.01.org
------------------------------
End of connman Digest, Vol 65, Issue 5
**************************************
