Send connman mailing list submissions to
        connman@lists.01.org

To subscribe or unsubscribe via email, send a message with subject or
body 'help' to
        connman-requ...@lists.01.org

You can reach the person managing the list at
        connman-ow...@lists.01.org

When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."

Today's Topics:

   1. Re: [RFC 2/8] network: Support ipconfig.c changes for IPv6 force option
      (Daniel Wagner)


----------------------------------------------------------------------

Date: Sat, 27 Mar 2021 15:09:38 +0100
From: Daniel Wagner <w...@monom.org>
Subject: Re: [RFC 2/8] network: Support ipconfig.c changes for IPv6
        force option
To: Jussi Laakkonen <jussi.laakko...@jolla.com>
Cc: connman@lists.01.org
Message-ID: <20210327140938.ryzjn4vhyjezb...@beryllium.lan>
Content-Type: text/plain; charset=us-ascii

Hi Jussi,

On Fri, Mar 26, 2021 at 05:58:19PM +0200, Jussi Laakkonen wrote:
> Add "false" to all functions using
> __connman_ipconfig_{enable,disable}_ipv6() except with
> __connman_network_enable_ipconfig(), in which the parameter is set by
> the caller. This is passed to autoconf_ipv6_set() to get IPv6 properly
> enabled again, when requested. Utilize the input force value with
> FIXED, MANUAL, DHCP and AUTO ipconfig method types when enabling
> ipconfig via network.c.

If I read it correctly the only case where you need to force is
in set_disconnected() and there you could use a force function.
I'd prefer not adding a parameter to all functions which is
in almost all cases the same value. Wouldn't

  __connman_ipconfig_force_[enable|disable]_ipv6()

work?

Thanks,
Daniel

------------------------------

Subject: Digest Footer

_______________________________________________
connman mailing list -- connman@lists.01.org
To unsubscribe send an email to connman-le...@lists.01.org


------------------------------

End of connman Digest, Vol 65, Issue 11
***************************************

Reply via email to