Send connman mailing list submissions to
connman@lists.01.org
To subscribe or unsubscribe via email, send a message with subject or
body 'help' to
connman-requ...@lists.01.org
You can reach the person managing the list at
connman-ow...@lists.01.org
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. RE: [PATCH] service: Prevent auto connection during passphrase request
(VAUTRIN Emmanuel (Canal Plus Prestataire))
2. RE: [PATCH] service: Prevent auto connection during passphrase request
(VAUTRIN Emmanuel (Canal Plus Prestataire))
3. RE: [PATCH] main: Cleanup of vendor class id and wifi config options
(VAUTRIN Emmanuel (Canal Plus Prestataire))
----------------------------------------------------------------------
Date: Thu, 13 May 2021 22:19:54 +0000
From: "VAUTRIN Emmanuel (Canal Plus Prestataire)"
<emmanuel.vaut...@cpexterne.org>
Subject: RE: [PATCH] service: Prevent auto connection during
passphrase request
To: Daniel Wagner <w...@monom.org>
Cc: "connman@lists.01.org" <connman@lists.01.org>
Message-ID: <pr1pr02mb4794ed6e891101dbe8bbdce993...@pr1pr02mb4794.eur
prd02.prod.outlook.com>
Content-Type: text/plain; charset="iso-8859-1"
De : Daniel Wagner <w...@monom.org>
Envoyé : jeudi 13 mai 2021 13:08
À : VAUTRIN Emmanuel (Canal Plus Prestataire) <emmanuel.vaut...@cpexterne.org>
Cc : connman@lists.01.org <connman@lists.01.org>
Objet : Re: [PATCH] service: Prevent auto connection during passphrase request
Hi Emmanuel,
On Mon, Apr 26, 2021 at 07:10:30PM +0000, VAUTRIN Emmanuel (Canal Plus
Prestataire) wrote:
> Avoid concurrent associations between a user connection to a secure
> service, blocked by an agent passphrase input request, and a starting
> auto connection on a different service of the same interface.
>
> This issue happens when the end-user wants to connect to a new secure
> Wifi network (W2) via an interface where another Wifi network (W1) is
> already connected. When doing that, the following steps happen:
> 1. Disconnection of current network (W1).
> 2. User-connection to W2, held by the passphrase request.
> 3. Auto-connection to a known available Wifi network (W1) succeeding.
> 4. User-connection to W2, reactivated by the passphrase response,
> failing, as another Wifi (W1) is already connected.
> In this configuration, W2 will never be able to connect.
Thanks for adding the commit message.
> DBG("service %p state %s connect reason %s -> %s",
> @@ -6779,6 +6792,13 @@ int __connman_service_connect(struct connman_service
> *service,
> if (service->hidden && err != -EINPROGRESS)
> service->pending = pending;
>
> + if (err == -EINPROGRESS) {
> + index = __connman_service_get_index(service);
> + g_hash_table_replace(passphrase_requested,
> + GINT_TO_POINTER(index),
> + GINT_TO_POINTER(true));
Ah I see you dropped the file descriptor and now you just store a
boolean. In this case you could just add a boolean variable called
passphrase_requested to 'struct service' and you could drop the hash
table completely. So this gets
service->passphrase_requested = true;
and in auto_connect_servcie() a simple
if (service->passphrase_requested)
return true;
is enough.
Thanks,
Daniel
------------------------------
Date: Thu, 13 May 2021 22:29:10 +0000
From: "VAUTRIN Emmanuel (Canal Plus Prestataire)"
<emmanuel.vaut...@cpexterne.org>
Subject: RE: [PATCH] service: Prevent auto connection during
passphrase request
To: Daniel Wagner <w...@monom.org>
Cc: "connman@lists.01.org" <connman@lists.01.org>
Message-ID: <pr1pr02mb479430a3d52caa842b3770cf93...@pr1pr02mb4794.eur
prd02.prod.outlook.com>
Content-Type: text/plain; charset="iso-8859-1"
Hi Daniel,
> Ah I see you dropped the file descriptor and now you just store a
> boolean. In this case you could just add a boolean variable called
> passphrase_requested to 'struct service' and you could drop the hash
> table completely. So this gets
>
> service->passphrase_requested = true;
>
> and in auto_connect_servcie() a simple
>
> if (service->passphrase_requested)
> return true;
>
> is enough.
These information are at interface level,
and shall be shared between all related services.
I doubt setting those at service side will solve the problem.
Best Regards,
Emmanuel
------------------------------
Date: Thu, 13 May 2021 22:30:42 +0000
From: "VAUTRIN Emmanuel (Canal Plus Prestataire)"
<emmanuel.vaut...@cpexterne.org>
Subject: RE: [PATCH] main: Cleanup of vendor class id and wifi config
options
To: Daniel Wagner <w...@monom.org>
Cc: "connman@lists.01.org" <connman@lists.01.org>
Message-ID: <pr1pr02mb4794378b8aa3141e1c940a6293...@pr1pr02mb4794.eur
prd02.prod.outlook.com>
Content-Type: multipart/alternative; boundary="_000_PR1PR02MB479437
8B8AA3141E1C940A6293519PR1PR02MB4794eurp_"
--_000_PR1PR02MB4794378B8AA3141E1C940A6293519PR1PR02MB4794eurp_
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Great,
Thank you Daniel
Emmanuel
________________________________
De : Daniel Wagner <w...@monom.org>
Envoy=E9 : jeudi 13 mai 2021 11:53
=C0 : VAUTRIN Emmanuel (Canal Plus Prestataire) <Emmanuel.VAUTRIN@cpexterne=
.org>
Cc : connman@lists.01.org <connman@lists.01.org>
Objet : Re: [PATCH] main: Cleanup of vendor class id and wifi config option=
s
Hi Emmanuel,
On Thu, May 06, 2021 at 09:45:01AM +0000, VAUTRIN Emmanuel (Canal Plus Pres=
tataire) wrote:
> Ensure homogeneity of config options management by replacing
> connman_option_get_string() by connman_setting_get_string(), and
> removing irrelevant option.h header file.
> Fix a memory leak on vendor class id option.
Nice cleanup. Patch applied.
Thanks,
Daniel
--_000_PR1PR02MB4794378B8AA3141E1C940A6293519PR1PR02MB4794eurp_
Content-Type: text/html; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
<html>
<head>
<meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Diso-8859-=
1">
<style type=3D"text/css" style=3D"display:none;"> P {margin-top:0;margin-bo=
ttom:0;} </style>
</head>
<body dir=3D"ltr">
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0);">
Great,</div>
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0);">
Thank you Daniel</div>
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0);">
Emmanuel<br>
</div>
<div id=3D"appendonsend"></div>
<hr style=3D"display:inline-block;width:98%" tabindex=3D"-1">
<div id=3D"divRplyFwdMsg" dir=3D"ltr"><font face=3D"Calibri, sans-serif" st=
yle=3D"font-size:11pt" color=3D"#000000"><b>De :</b> Daniel Wagner <wagi=
@monom.org><br>
<b>Envoy=E9 :</b> jeudi 13 mai 2021 11:53<br>
<b>=C0 :</b> VAUTRIN Emmanuel (Canal Plus Prestataire) <Emmanuel.VAUTRIN=
@cpexterne.org><br>
<b>Cc :</b> connman@lists.01.org <connman@lists.01.org><br>
<b>Objet :</b> Re: [PATCH] main: Cleanup of vendor class id and wifi config=
options</font>
<div> </div>
</div>
<div class=3D"BodyFragment"><font size=3D"2"><span style=3D"font-size:11pt;=
">
<div class=3D"PlainText">Hi Emmanuel,<br>
<br>
On Thu, May 06, 2021 at 09:45:01AM +0000, VAUTRIN Emmanuel (Canal Plus Pres=
tataire) wrote:<br>
> Ensure homogeneity of config options management by replacing<br>
> connman_option_get_string() by connman_setting_get_string(), and<br>
> removing irrelevant option.h header file.<br>
> Fix a memory leak on vendor class id option.<br>
<br>
Nice cleanup. Patch applied.<br>
<br>
Thanks,<br>
Daniel<br>
</div>
</span></font></div>
</body>
</html>
--_000_PR1PR02MB4794378B8AA3141E1C940A6293519PR1PR02MB4794eurp_--
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list -- connman@lists.01.org
To unsubscribe send an email to connman-le...@lists.01.org
------------------------------
End of connman Digest, Vol 67, Issue 8
**************************************
