Hi Marcel:
Can you push your latest code to Moblin git tree or point out how I can pull 
you latest tree. So that I can help you review and verify the code. :)

-----Original Message-----
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Marcel Holtmann
Sent: 2008年11月25日 4:05
To: [email protected]
Cc: Liu, Bing Wei; Gao, Bin
Subject: Re: [connman] found a small issue in connman

Hi Martin,

> I am reading the code in blow git tree.
> http://moblin.org/repos/projects/connman.git
> Not sure It is still the connman git tree you are using.
>
> I found a small issue in the code, please review below patch.
>
> diff --git a/include/driver.h b/include/driver.h
> index 6d212d8..696c53f 100644
> --- a/include/driver.h
> +++ b/include/driver.h
> @@ -41,7 +41,7 @@ extern "C" {
> struct connman_driver {
>        const char *name;
>        enum connman_element_type type;
> -       enum connman_element_type subtype;
> +       enum connman_element_subtype subtype;
>        int priority;
>        int (*probe) (struct connman_element *element);
>        void (*remove) (struct connman_element *element);

good catch. I have a fix for that in my unpushed tree.

Regards

Marcel

_______________________________________________
connman mailing list
[email protected]
https://lists.moblin.org/mailman/listinfo/connman
_______________________________________________
connman mailing list
[email protected]
https://lists.moblin.org/mailman/listinfo/connman

Reply via email to