Might want to: 1) wait for the mdsal patches to get merged 2) wait for the merge jobs to complete successfully 3) then recheck the controller patch 4) then merge
I believe that is how we usually handle it... others chime in if this is trivial enough to remove jenkins-releng and avoid possible build breakages. I have no real philosophy on this one. Regards, Ryan Goulding On Thu, Mar 2, 2017 at 11:41 AM, Tom Pantelis <tompante...@gmail.com> wrote: > I added +2. What's the next step? I can remove jenkins-releng and merge > that way. > > On Thu, Mar 2, 2017 at 11:35 AM, Ryan Goulding <ryandgould...@gmail.com> > wrote: > >> Hi Martin, >> >> I reached out to Tom offline and asked him to review these changes, and >> explained that they won't get +1 from jenkins-releng until the mdsal >> patches are merged. I have added +1. After he gives his approval, please >> coordinate the merge directly with him. >> >> Tom, can you please take a look at the package refactoring here? >> >> Thanks, >> >> Ryan >> >> On Thu, Mar 2, 2017 at 10:59 AM, Martin Ciglan -X (mciglan - PANTHEON >> TECHNOLOGIES at Cisco) <mcig...@cisco.com> wrote: >> >>> Hi >>> >>> >>> We've got approval from one BGPCEP representative, waiting for rest >>> of Controller & BGPCEP commiters. >>> >>> >>> Please verify & update: >>> https://wiki.opendaylight.org/view/Simultaneous_Release/Carb >>> on/Waiver/API/Records#MD-SAL_Binding_Generator_API_Change_Waiver >>> >>> Many thanks in advance >>> >>> >>> Best Regards >>> >>> >>> Martin >>> >>> ------------------------------ >>> *Od:* controller-dev-boun...@lists.opendaylight.org < >>> controller-dev-boun...@lists.opendaylight.org> v mene používateľa Jakub >>> Toth -X (jatoth - PANTHEON TECHNOLOGIES at Cisco) >>> *Odoslané:* 24. februára 2017 11:21 >>> *Komu:* mdsal-...@lists.opendaylight.org; controller-dev; ' >>> rele...@lists.opendaylight.org'; d...@lists.opendaylight.org >>> *Predmet:* [controller-dev] MD-SAL Binding Generator API Change Waiver >>> >>> >>> Hi, >>> >>> Based on transfer of Binding generator v1 from Yangtools project to >>> MDSAL in past, we need to finalize this process by refactoring package >>> naming: >>> >>> · org.opendaylight.yangtools -> org.mdsal.binding >>> >>> · org.opendaylight.yangtools.sal -> org.mdsal.binding >>> >>> >>> This refactoring is done in subsequent steps, covering all necessary >>> modules. Based on experience, this should also help users to address >>> possible Binding generator v1 issues in MDSAL project, not in Yangtools. >>> >>> Impacted project is OpenDaylight controller & BGPCEP. >>> >>> · MD-SAL Binding Generator API Change Waiver >>> >>> o https://wiki.opendaylight.org/view/Simultaneous_Release/Carb >>> on/Waiver/API/Records#MD-SAL_Binding_Generator_API_Change_Waiver >>> >>> · MD-SAL: Model-Driven Service Adaptation Layer >>> >>> o Gerrit >>> >>> § https://git.opendaylight.org/gerrit/#/c/52107 >>> >>> § https://git.opendaylight.org/gerrit/#/c/52108 >>> >>> § https://git.opendaylight.org/gerrit/#/c/52109 >>> >>> § https://git.opendaylight.org/gerrit/#/c/52110 >>> >>> § https://git.opendaylight.org/gerrit/#/c/52158 >>> >>> o Bug >>> >>> § https://bugs.opendaylight.org/show_bug.cgi?id=6859 >>> >>> · OpenDaylight controller >>> >>> - https://git.opendaylight.org/gerrit/#/c/52170/ >>> >>> >>> >>> - BGP/PCEP protocol library >>> - https://git.opendaylight.org/gerrit/#/c/52561/ >>> - https://bugs.opendaylight.org/show_bug.cgi?id=6859 >>> - Representative: Claudio D. Gasparini >>> >>> >>> >>> Regards, >>> >>> Jakub Toth >>> >>> >>> >>> [image: logo_Grey] >>> >>> >>> >>> *Jakub Toth* >>> >>> Engineer - Software >>> >>> jat...@cisco.com >>> >>> Tel: >>> >>> *Cisco Systems, Inc.* >>> >>> >>> >>> >>> Slovakia >>> cisco.com >>> >>> >>> >>> [image: http://www.cisco.com/assets/swa/img/thinkbeforeyouprint.gif]Think >>> before you print. >>> >>> This email may contain confidential and privileged material for the sole >>> use of the intended recipient. Any review, use, distribution or disclosure >>> by others is strictly prohibited. If you are not the intended recipient (or >>> authorized to receive for the recipient), please contact the sender by >>> reply email and delete all copies of this message. >>> >>> Please click here >>> <http://www.cisco.com/web/about/doing_business/legal/cri/index.html> >>> for Company Registration Information. >>> >>> >>> >>> _______________________________________________ >>> controller-dev mailing list >>> controller-dev@lists.opendaylight.org >>> https://lists.opendaylight.org/mailman/listinfo/controller-dev >>> >>> >> >> _______________________________________________ >> controller-dev mailing list >> controller-dev@lists.opendaylight.org >> https://lists.opendaylight.org/mailman/listinfo/controller-dev >> >> >
_______________________________________________ controller-dev mailing list controller-dev@lists.opendaylight.org https://lists.opendaylight.org/mailman/listinfo/controller-dev
![http://www.cisco.com/assets/swa/img/thinkbeforeyouprint.gif]Think](http://www.cisco.com/assets/swa/img/thinkbeforeyouprint.gif]Think){kind=link}