On Tue, Jun 26, 2018 at 1:45 PM, Robert Varga <n...@hq.sk> wrote: > On 26/06/18 13:40, Faseela K wrote: > > Thanks a lot Michael. > > > > This looks like an MDSAL bug, that even if the yang modules are > > separated by namespaces, there is some bug somewhere that it is not > > honored properly. > > > > I was able to change the module names in serviceutils(so that it looks > > different from genius), and then when I install the feature, I am not > > hitting the error. > > > > @Robert : Can we get someone to take a look at > > https://jira.opendaylight.org/browse/MDSAL-354 > > > > And fix, else we have no other option than to workaround by renaming > > the yang modules in serviceutils. > > Module names form a global flat namespace, as per > https://tools.ietf.org/html/rfc7950#section-6.2.1 and therefore module > names within a system must be unique and furthermore module > name/namespace mapping must be a bijection. >
Oh! So loading https://github.com/opendaylight/genius/blob/5ad5d6bf9b17bb66ddb35e56e895d220795febc6/srm/api/src/main/yang/srm-rpcs.yang together with https://github.com/opendaylight/serviceutils/blob/7162c48453a8c369ca7abbe3e83ae269977c9f96/srm/api/src/main/yang/srm-rpcs.yang could really never work? Would it then be crazy to suggest, certainly more as a medium term enhancement request than a short term blocker bug, that it would be really useful to get a much clearer failure in the log highlighting this, instead the current obscure internal errors seen in https://jira.opendaylight.org/browse/GENIUS-169 ? If I understand what happened here correctly, then -in an ideal world- we really should have failed much earlier, much more clearly... I'm thinking something like : "bundle org.opendaylight.serviceutils.srm-api failed to load because its srm-rpcs.yang steps on the 'srm-rpcs' module name already used by srm-rpcs.yang in org.opendaylight.genius.srm-api", and that should mark the bundle as not activated (which we could pick up on in ready & diagstatus) - kind of thing? That would be cool and very helpful, instead of the current (apparent) silent ignoring of a module it does not like... Faseela, renaming the yang modules in serviceutils:srm is obviously definitely the way to resolve this and move forward!
_______________________________________________ controller-dev mailing list controller-dev@lists.opendaylight.org https://lists.opendaylight.org/mailman/listinfo/controller-dev