> On Sun, Jun 08, 2003 at 04:17:24PM +0200, Luca Berra wrote:
>>/me admits his ignorance of the existance of mandrake cvs, i will
>> search for it and see if i have anything else to patch.
>>
> got a spec from samba cvs and would like some comments:
>
BTW, note the way things work, the samba release scripts replace any
PVERSION or PRELEASE text in any file ending with .tmpl (including the
samba2.spec.tmpl in packaging) so if you want a standard (ie not from
source tarball) build, you must replace their 3.0.0beta1 and 1 with
PVERSION and PRELEASE again in the %define pversion and %define prelease
lines (we do some tests on that to decide to disable certain things which
require sources not in the samba tree etc).
> why kill wrepld? the ldap scripts?
Samba team recommendation is that wrepld will not be production-ready for
3.0.0, I don't want someone thinking it is by supplying an init script
etc. In fact, I think wrepld isn't in the default target any more.
If you're meaning smbldap-tools, well they still aren't available in any
3_0 CVS tag, and aren't in any of the samba3 releases so far. The samba
team mentioned that they (or another solution) will be available in a
final release, and as soon as I see them going into CVS, I will put them
back where they belong.
>
> make --with system work:
> @@ -110,8 +110,8 @@
> # To use it, do rpm [-ba|--rebuild] --with 'xxx'
> # Check if the rpm was built with the defaults, otherwise we inform the
> user %define build_non_default 0
> -%{?_with_system: %{expand: %%define build_system 1}}
> -%{?_without_system: %{expand: %%define build_system 0}}
> +%{?_with_system: %{expand: %%global build_system 1}}
> +%{?_without_system: %{expand: %%global build_system 0}}
> %{?_with_acl: %{expand: %%global build_acl 1}}
> %{?_with_acl: %{expand: %%define build_non_default 1}}
> %{?_without_acl: %{expand: %%global build_acl 0}}
>
I think I fixed this one in samba-2.2.x already, just haven't done a
--with-system build since I added the lib package to samba3. Thanks. Since
there will be delays in uploading beta1 to cooker anyway, I will try and
fix this and a few other things that could be done more cleanly.
>
> stops creating directory %{1} at random places
> @@ -638,8 +638,8 @@
> %prep
>
> # Allow users to query build options with --with options:
> -#%define opt_status(%1) %(echo %{1})
> -#%( [ -d %{1} ]||mkdir -p %{1}; [ -w %{1} ] && echo %{1})
> +#define opt_status(%1) %(echo %{1})
> +#( [ -d %{1} ]||mkdir -p %{1}; [ -w %{1} ] && echo %{1})
> %if %{?_with_options:1}%{!?_with_options:0}
> %define opt_status(%{1}) %(if [ %{1} -eq 1 ];then echo
> enabled;else echo disabled;fi) #exit 1
>
> fixes percent in %changelog
Really minor issue, it's only evident on macros which expand by default
(ie %install with debug support) and in the changelog list, so I don't see
the point of changing historic changelogs if they cause no harm (note the
%install ones were fixed).
> vi samba.spec
> /%changelog
> :.,$s/\([^%]\)%\([^%]\)/\1%%\1
>
> i noticed two other things:
> 1) "non unix account range" has been replaced by "idmap uid" and "idmap
> gid", but not in smb.conf
Yes this is a very recent change (it was changed from winbind uid etc
about 4 months ago, then again to idmap in the past few days), and the
default smb.conf needs a lot of work, which I will start now that I can
upgrade my test box (was used for the article I mentioned).
> 2) manpage for smb.conf is broken in the beta1
> tarball or in samba cvs, and i am not able to rebuild the docs (xsltproc
> hangs processing smb.conf.5.xml)
That should be reported upstream ...
Regards,
Buchan
