[Cooker] Re: [CHRPM] kernel-2.4.17.1.mdk-1-1mdk

[Reinhard Katzmann]

Guillaume Rousse <[EMAIL PROTECTED]> schrieb:
> arch/i386/kernel/kernel.o: In function `sys_call_table':
> arch/i386/kernel/kernel.o(.data+0x268): undefined reference to `sys_quotactl'
> kernel/kernel.o(.data+0xe64): undefined reference to `nr_dquots'
> make[1]: *** [kallsyms] Erreur 1
> make[1]: Quitte le r%/1€Œiso8859-15�épertoire `/usr/src/linux-2.4.17-1mdk'
> make: *** [vmlinux] Erreur 2
> 
> Am i missing something here ?

Same here, I did not include quota fs support. For some reason which I
don't see any need for (I grepped kernel and arch directories for "quot" but
the two places where I found quota could be easily commented, so those were
only definitions. Maybe the diskquota fs driver needs it but then it should
not be defined in the quota fs itself.

The two places which I changed: (grep output)
arch/i386/kernel/entry.S:/*     .long SYMBOL_NAME(sys_quotactl) */
arch/i386/kernel/entry.S~:      .long SYMBOL_NAME(sys_quotactl)

kernel/sysctl.c:        /*      {FS_NRDQUOT, "dquot-nr", &nr_dquots, 2*sizeof(int),  
0444, NULL, &proc_dointvec},*/
kernel/sysctl.c~:       {FS_NRDQUOT, "dquot-nr", &nr_dquots, 2*sizeof(int),

I find it very strange to find a reference for disk quota which can be easily
removed from config inside the static fs_table of the kernel. According to
the documentation nothing but ext2 does support quota and it is also a change
which should not be done to a stable kernel tree. I recommand to remove
this patch as well as the change to entry.S.:

kernel/sysctl.c
@@ -295,8 +296,8 @@
         0444, NULL, &proc_dointvec},
        {FS_MAXFILE, "file-max", &files_stat.max_files, sizeof(int),
         0644, NULL, &proc_dointvec},
-       {FS_NRDQUOT, "dquot-nr", &nr_dquots, 2*sizeof(int),
-        0444, NULL, &proc_dointvec},
+       {FS_NRDQUOT, "dquot-nr", &nr_dquots, 2*sizeof(int),
+        0444, NULL, &proc_dointvec},
        {FS_DENTRY, "dentry-state", &dentry_stat, 6*sizeof(int),
         0444, NULL, &proc_dointvec},
        {FS_OVERFLOWUID, "overflowuid", &fs_overflowuid, sizeof(int), 0644, NULL,

+++ arch/i386/kernel/entry.S    Sat Jan  5 19:26:18 2002
@@ -555,7 +555,7 @@
        .long SYMBOL_NAME(sys_init_module)
        .long SYMBOL_NAME(sys_delete_module)
        .long SYMBOL_NAME(sys_get_kernel_syms)  /* 130 */
-       .long SYMBOL_NAME(sys_quotactl)
+/*     .long SYMBOL_NAME(sys_quotactl) */
        .long SYMBOL_NAME(sys_getpgid)
        .long SYMBOL_NAME(sys_fchdir)
        .long SYMBOL_NAME(sys_bdflush)


Another problem: I was unable to boot from 2.4.17. I will report
this in an extra mail (as it is probably mkinitrd related, though
I'm unsure).

With best regards,

Reinhard
-- 
Software-Engineer, Developer for Embedded Devices
Project: HyperPen Tablet USB Driver for Linux 
GnuPG Public Key available on request

msg50346/pgp00000.pgp
Description: PGP signature