Laurent MONTEL wrote:
> --=-=-=
> Name        : kdenetwork                   Relocations: (not relocateable)
> Version     : 3.0.3                             Vendor: MandrakeSoft
> Release     : 15mdk                         Build Date: Mon Sep 16 07:52:38 2002
> Install date: (not installed)               Build Host: ke.mandrakesoft.com
> Group       : Development/KDE and Qt        Source RPM: (none)
> Size        : 3247738                          License: GPL
> Packager    : Mandrake Linux KDE Team <[EMAIL PROTECTED]>
> URL         : http://www.kde.org/
> Summary     : K Desktop Environment - Network Applications
> Description :
> Networking applications for the K Desktop Environment.
> 
> --=-=-=
> 
> * Mon Sep 16 2002 Laurent MONTEL <[EMAIL PROTECTED]> 3.0.3-15mdk
> 
> - Fix update/clean menu in lisa package
> - Fix menu in lisa package
> 

Will the lisa init script be fixed? This package still creates bad 
config files (with extra "n " in the list of IPs/Netmasks.



-------- Original Message --------
Subject: [Cooker] lisa init script broken by gprintf
Date: Sun, 15 Sep 2002 20:30:32 +0200 (SAST)
From: Buchan Milne <[EMAIL PROTECTED]>
Reply-To: [EMAIL PROTECTED]
To: <[EMAIL PROTECTED]>
CC: <[EMAIL PROTECTED]>


Since I have a clean rc2 install now, I tested the lisa init script, and
it seems the creation of the default /etc/lisarc is broken when the script
is gprintified.

Here is my test:

(/etc/rc.d/init.d/lisa.orig is the one shipped with the lisa rpm,
/etc/rc.d/init.d/lisa is the one which I have hacked to fix:

[root@bgmilne root]# rm -f /etc/lisarc
[root@bgmilne root]# service lisa.orig restart
Stopping lisa:                                                  [  OK  ]
No config file, generating one, please run kcontrol as root to customise
Starting lisa:                                                  [  OK  ]
[root@bgmilne root]# cp /etc/lisarc /etc/lisarc.orig
[root@bgmilne root]# rm -f /etc/lisarc
[root@bgmilne root]# service lisa restart
Stopping lisa:                                                  [  OK  ]
No config file, generating one, please run kcontrol as root to customise
Starting lisa:                                                  [  OK  ]
[root@bgmilne root]# diff -u /etc/lisarc.orig /etc/lisarc
--- /etc/lisarc.orig    2002-09-15 20:20:49.000000000 +0200
+++ /etc/lisarc 2002-09-15 20:20:57.000000000 +0200
@@ -1,5 +1,5 @@
-AllowedAddresses=n 192.168.0.248/255.255.255.0;
-BroadcastNetwork=n 192.168.0.248/255.255.255.0;
+AllowedAddresses=192.168.0.248/255.255.255.0;
+BroadcastNetwork=192.168.0.248/255.255.255.0;
  DeliverUnnamedHosts=0
  FirstWait=30
  MaxPingsAtOnce=256

It seems the script in the lisa package adds an additional "n " to the
list of IPs/Netmasks, which breaks lisa (runs, but doesn't show any
hosts).

diff'ing the two (diff -u /etc/rc.d/init.d/lisa.orig
/etc/rc.d/init.d/lisa) gives:

-                                       IPNMS=`gprintf "%s"\n"
"$IPNMS"$IPNM;"`
+                                       IPNMS=`gprintf "$IPNMS""$IPNM;"`


This is generated when gprintified from the line:
IPNMS=`echo "$IPNMS""$IPNM;"`

Maybe this can be fixed by substituting the working gprintf above for the
echo in the original script?

Regards,
Buchan

-- 
|----------------Registered Linux User #182071-----------------|
Buchan Milne                Mechanical Engineer, Network Manager
Cellphone * Work            +27 82 472 2231 * +27 21 8828820x121
Stellenbosch Automotive Engineering         http://www.cae.co.za
GPG Key                   http://ranger.dnsalias.com/bgmilne.asc
1024D/60D204A7 2919 E232 5610 A038 87B1 72D6 AC92 BA50 60D2 04A7


Reply via email to