[
https://issues.apache.org/jira/browse/HADOOP-2811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12568805#action_12568805
]
Hadoop QA commented on HADOOP-2811:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12375543/patch-2811.txt
against trunk revision 619744.
@author +1. The patch does not contain any @author tags.
tests included -1. The patch doesn't appear to include any new or modified
tests.
Please justify why no tests are needed for this patch.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new javac compiler
warnings.
release audit +1. The applied patch does not generate any new release
audit warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
contrib tests +1. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1797/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1797/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1797/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1797/console
This message is automatically generated.
> method Counters.makeCompactString() does not insert separator char ','
> between the counters of different groups.
> ----------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-2811
> URL: https://issues.apache.org/jira/browse/HADOOP-2811
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.16.0
> Reporter: Runping Qi
> Assignee: Runping Qi
> Priority: Critical
> Fix For: 0.16.1
>
> Attachments: patch-2811.txt
>
>
> The corrent code is:
> {code}
> public synchronized String makeCompactString() {
> StringBuffer buffer = new StringBuffer();
> for(Group group: this){
> boolean first = true;
> for(Counter counter: group) {
> if (first) {
> first = false;
> } else {
> buffer.append(',');
> }
> buffer.append(group.getDisplayName());
> buffer.append('.');
> buffer.append(counter.getDisplayName());
> buffer.append('=');
> buffer.append(counter.getCounter());
> }
> }
> return buffer.toString();
> }
> {code}
> The correct code should be like:
> {code}
> public synchronized String makeCompactString() {
> StringBuffer buffer = new StringBuffer();
> boolean first = true;
> for(Group group: this){
>
> for(Counter counter: group) {
> if (first) {
> first = false;
> } else {
> buffer.append(',');
> }
> buffer.append(group.getDisplayName());
> buffer.append('.');
> buffer.append(counter.getDisplayName());
> buffer.append('=');
> buffer.append(counter.getCounter());
> }
> }
> return buffer.toString();
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
