[
https://issues.apache.org/jira/browse/HADOOP-2833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573525#action_12573525
]
Hadoop QA commented on HADOOP-2833:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12376758/2833_20080228.patch
against trunk revision 619744.
@author +1. The patch does not contain any @author tags.
tests included +1. The patch appears to include 3 new or modified tests.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new javac compiler
warnings.
release audit +1. The applied patch does not generate any new release
audit warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
contrib tests +1. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1867/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1867/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1867/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1867/console
This message is automatically generated.
> JobClient.submitJob(...) should not use "Dr Who" as a default username
> ----------------------------------------------------------------------
>
> Key: HADOOP-2833
> URL: https://issues.apache.org/jira/browse/HADOOP-2833
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 2833_20080225.patch, 2833_20080227.patch,
> 2833_20080227b.patch, 2833_20080228.patch
>
>
> In JobClient line 530, we have
> {code}
> String user = System.getProperty("user.name");
> job.setUser(user != null ? user : "Dr Who");
> {code}
> Since a ugi is already obtained in the earlier codes, we should get the
> username from ugi, not System.getProperty("user.name"). Also, Exception
> should be thrown if the username is null, instead of using a default.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
