[
https://issues.apache.org/jira/browse/HADOOP-2423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12578181#action_12578181
]
Hadoop QA commented on HADOOP-2423:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12377629/2423_20080311.patch
against trunk revision 619744.
@author +1. The patch does not contain any @author tags.
tests included -1. The patch doesn't appear to include any new or modified
tests.
Please justify why no tests are needed for this patch.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new javac compiler
warnings.
release audit +1. The applied patch does not generate any new release
audit warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
contrib tests +1. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1950/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1950/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1950/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1950/console
This message is automatically generated.
> The codes in FSDirectory.mkdirs(...) is inefficient.
> ----------------------------------------------------
>
> Key: HADOOP-2423
> URL: https://issues.apache.org/jira/browse/HADOOP-2423
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.1
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 2423_20080130.patch, 2423_20080303.patch,
> 2423_20080304.patch, 2423_20080304b.patch, 2423_20080304c.patch,
> 2423_20080304d.patch, 2423_20080310.patch, 2423_20080311.patch
>
>
> FSDirectory.mkdirs(...) creates List<String> v to store all dirs. e.g.
> {code}
> //Suppose
> src = "/foo/bar/bas/"
> //Then,
> v = {"/", "/foo", "/foo/bar", "/foo/bar/bas"}
> {code}
> For each directory string *cur* in v, no matter *cur* already exists or not,
> it will try to do a unprotectedMkdir(cur, ...). Then, *cur* is parsed to
> byte[][] in INodeDirectory.addNode (...).
> We don't need to do the parsing for each string in v. Instead, byte[][]
> should be stored. Also, the loop should not continue once it finds an
> existing subdirectory.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
