[ 
https://issues.apache.org/jira/browse/HADOOP-2783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12580282#action_12580282
 ] 

Hemanth Yamijala commented on HADOOP-2783:
------------------------------------------

Minor. The testInterrupt method is probably not hanging because of the sleep in 
the longRpcCall method, which is clearly intended. It should be failing because 
you are generating a random port (by mistake) and trying to connect to that, 
rather than reusing serverport. So it should be timing out. Though the intended 
effect is still tested, maybe it will be clearer to correct this.

Otherwise +1.

Please make this minor change and make it available.

> hod/hodlib/Common/xmlrpc.py uses HodInterruptException without importing it
> ---------------------------------------------------------------------------
>
>                 Key: HADOOP-2783
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2783
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/hod
>    Affects Versions: 0.16.0, 0.16.1, 0.17.0
>            Reporter: Vinod Kumar Vavilapalli
>            Assignee: Vinod Kumar Vavilapalli
>            Priority: Minor
>             Fix For: 0.17.0
>
>         Attachments: HADOOP-2783, HADOOP-2783.1
>
>
> And because of this no-import of HodInterruptException in 
> hod/hodlib/Common/xmlrpc.py, HOD fails with an exception, when it gets 
> interrupted by user(e.g ^C) while it is performing any xmlrpc request. One 
> line fix.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to