[
https://issues.apache.org/jira/browse/HADOOP-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12584603#action_12584603
]
Arun C Murthy commented on HADOOP-3140:
---------------------------------------
Looks good, couple of comments:
1. I'm a little bothered by
{noformat}
+ // If the TIP is already completed and the task reports as SUCCEEDED then
+ // mark the task as KILLED.
+ // In case of task with no promotion the task tracker will mark the task
+ // as SUCCEEDED.
+ if (wasComplete && (status.getRunState() == TaskStatus.State.SUCCEEDED)) {
+ status.setRunState(TaskStatus.State.KILLED);
+ }
boolean change = tip.updateStatus(status);
if (change) {
TaskStatus.State state = status.getRunState();
{noformat}
Normally I'd expect the first check inside the 'if (change)' to make sure the
same status isn't being processed twice, and wrongly manipulates the state of
the TIP - I'm happy if you can confirm that this works... just being careful.
2. Please bump up TaskUmbilicalProtocol's version number.
> JobTracker should not try to promote a (map) task if it does not write to DFS
> at all
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-3140
> URL: https://issues.apache.org/jira/browse/HADOOP-3140
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Runping Qi
> Assignee: Amar Kamat
> Fix For: 0.17.0
>
> Attachments: HADOOP-3140-v1.patch
>
>
> In most cases, map tasks do not write to dfs.
> Thus, when they complete, they should not be put into commit_pending queue at
> all.
> This will improve the task promotion significantly.
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
