[ 
https://issues.apache.org/jira/browse/HADOOP-3258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12589219#action_12589219
 ] 

Hadoop QA commented on HADOOP-3258:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12380167/patch-3258.txt
against trunk revision 645773.

    @author +1.  The patch does not contain any @author tags.

    tests included +1.  The patch appears to include 3 new or modified tests.

    javadoc -1.  The javadoc tool appears to have generated 1 warning messages.

    javac +1.  The applied patch does not generate any new javac compiler 
warnings.

    release audit +1.  The applied patch does not generate any new release 
audit warnings.

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

    core tests -1.  The patch failed core unit tests.

    contrib tests +1.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2240/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2240/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2240/artifact/trunk/build/test/checkstyle-errors.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2240/console

This message is automatically generated.

> FileOutputFormat should have a method to create custom files under the 
> outputdir with a unique name per task to avoid name collision
> ------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3258
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3258
>             Project: Hadoop Core
>          Issue Type: New Feature
>          Components: mapred
>         Environment: all
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>             Fix For: 0.18.0
>
>         Attachments: patch-3258.txt, patch-3258.txt
>
>
> Currently, if a M/R code creates a file, it is the responsibility of the M/R 
> code to avoid file name collisions from different tasks.
> Hadoop should provide an API that creates unique file names based on the task 
> type (map or reduce) and the task ID. Similarly to how output files, 
> part-#####, are created.
> The proposed patch adds 2 static methods to the {{FileOutputFormat}}
> {nofomat}
>   public static String getUniqueName(JobConf conf, String name);
>   public static Path getPathForCustomFile(JobConf conf, String name);
> {nofomat}
> The first one adds task type and task ID to the given name.
> The second gives a PATH to a file in the working outputdir using a file name 
> namespaced by the first method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to