[ 
https://issues.apache.org/jira/browse/HADOOP-3677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614247#action_12614247
 ] 

Hadoop QA commented on HADOOP-3677:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12386129/HADOOP-3677-trunk.patch
  against trunk revision 677470.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2885/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2885/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2885/artifact/trunk/build/test/checkstyle-errors.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2885/console

This message is automatically generated.

> Problems with generation stamp upgrade
> --------------------------------------
>
>                 Key: HADOOP-3677
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3677
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.0
>            Reporter: Konstantin Shvachko
>            Assignee: Raghu Angadi
>            Priority: Blocker
>             Fix For: 0.18.0
>
>         Attachments: HADOOP-3677-branch-018.patch, HADOOP-3677-trunk.patch, 
> HADOOP-3677-trunk.patch
>
>
> # The generation stamp upgrade renames blocks' meta-files so that the name 
> contains the block generation stamp as stated in HADOOP-2656.
> If a data-node has blocks that do not belong to any files and the name-node 
> asks the data-node to remove those blocks 
> during or before the upgrade started the data-node will remove the blocks but 
> not the meta-files because their names 
> are still in the old format which is not recognized by the new code. So we 
> can end up with a number of garbage files which
> will be hard to recognize that they are unused and the system will never 
> remove them automatically.
> I think this should be handled by the upgrade code in the end, but may be it 
> will be right to fix HADOOP-3002 for the 0.18 release,
> which will avoid scheduling block removal when the name-node is in safe-mode.
> # I was not able to get the upgrade -force option to work. This option lets 
> the name-node proceed with a distributed upgrade even if
> the data-nodes are not able to complete their local upgrades. Did we test 
> this feature at all for the generation stamp upgrade?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to