[
https://issues.apache.org/jira/browse/HADOOP-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622925#action_12622925
]
Raghu Angadi commented on HADOOP-3935:
--------------------------------------
Even if there is a +1, normal procedure is to commit only after a patch goes
through Hudson. Hudson does quite a bit more than running unit tests.
Even if we know some tests will fail, we still run it through Hudson. And
before committing we just describe why a particular failure is ok and expected.
Also, traditionally for Hadoop, the commit message followed Doug's format : "I
just committed this. [if committer and developer is different] thanks Johan!".
Just FYI.
> Extract classes from DataNode.java
> ----------------------------------
>
> Key: HADOOP-3935
> URL: https://issues.apache.org/jira/browse/HADOOP-3935
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Johan Oskarsson
> Assignee: Johan Oskarsson
> Priority: Trivial
> Fix For: 0.19.0
>
> Attachments: HADOOP-3935.patch, HADOOP-3935.patch, HADOOP-3935.patch,
> patch.sh
>
>
> DataNode.java is becoming hard to navigate with over 3000 lines of code. I
> suggest moving some of the classes out into their own files in the same
> package. This will also make it easier to see how the classes depend on each
> other and to see what code belongs where.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
