[ 
https://issues.apache.org/jira/browse/HADOOP-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623529#action_12623529
 ] 

Hadoop QA commented on HADOOP-3963:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12388337/patch0.txt
  against trunk revision 686893.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
tests.
                        Please justify why no tests are needed for this patch.

    -1 javadoc.  The javadoc tool appears to have generated 1 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3067/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3067/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3067/artifact/trunk/build/test/checkstyle-errors.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3067/console

This message is automatically generated.

> libhdfs should never exit on its own but rather return errors to the calling 
> application
> ----------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3963
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3963
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: libhdfs
>            Reporter: Pete Wyckoff
>            Assignee: Pete Wyckoff
>            Priority: Minor
>         Attachments: patch0.txt
>
>
> A a library, libhdfs would be better to return errors rather than directly 
> exiting. This way the calling application can determine what to do on error. 
> And it is more unix library like to handle errors this way.
> Some applications like fuse-dfs need to handle the exit themselves after 
> emitting an appropriate error message to its log.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to