[
https://issues.apache.org/jira/browse/HADOOP-4174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631523#action_12631523
]
Hadoop QA commented on HADOOP-4174:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12390163/NNProtocol.patch
against trunk revision 695844.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3274/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3274/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3274/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3274/console
This message is automatically generated.
> Move non-client methods ou of ClientProtocol
> --------------------------------------------
>
> Key: HADOOP-4174
> URL: https://issues.apache.org/jira/browse/HADOOP-4174
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.17.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 0.19.0
>
> Attachments: NNProtocol.patch, NNProtocol.patch
>
>
> 3 ClientProtocol methods {{getEditLogSize()}}, {{rollEditLog()}},
> {{rollFSImage()}} are never called and should not be by DFSClient.
> These methods should be moved into NamenodeProtocol.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
