[
https://issues.apache.org/jira/browse/HADOOP-4178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634067#action_12634067
]
Vinod K V commented on HADOOP-4178:
-----------------------------------
Some quick review comments:
- In the test-case, there is some code-duplication writing the tags
"<property>", "<name>" etc. This can be avoided, say, by having a method that
writes a single key-val pair to the configuration.
- Two look-ups are being made for getting each configuration item (in
getReclaimTimeLimit, isPrioritySupported etc.), this can be a single look-up.
This precludes us from logging proper error messages while using default
values, but don't know for sure if we really need those log messages.
> The capacity scheduler's defaults for queues should be configurable.
> --------------------------------------------------------------------
>
> Key: HADOOP-4178
> URL: https://issues.apache.org/jira/browse/HADOOP-4178
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/capacity-sched
> Affects Versions: 0.19.0
> Reporter: Owen O'Malley
> Assignee: Sreekanth Ramakrishnan
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: HADOOP-4178-1.patch, HADOOP-4178-2.patch
>
>
> The default values for the queue attributes should be configurable rather
> than hard coded.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
