[ 
https://issues.apache.org/jira/browse/HADOOP-4244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634240#action_12634240
 ] 

Nigel Daley commented on HADOOP-4244:
-------------------------------------

Patch review:

"Running Eclipse tests." -> 
  "Running Eclipse classpath verification."

"-1 Eclipse tests.  The patch failed Eclipse unit tests." ->
  "+1 Eclipse classpath.  The patch causes the Eclipse classpath to differ from 
the contents of the lib directory."

"+1 Eclipse tests.  The patch passed Eclipse unit tests." ->
  "+1 Eclipse tests.  The patch retains Eclipse classpath integrity."



> In "ant test-patch", runContribTestOnEclipseFiles should not be run on Hudson 
> only
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-4244
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4244
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: build, test
>            Reporter: Tsz Wo (Nicholas), SZE
>         Attachments: 4244_20080924.patch
>
>
> runContribTestOnEclipseFiles is ONLY executed on Hudson but it won't be 
> executed by default.  So it won't be run when developers run "ant test-patch".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to