[
https://issues.apache.org/jira/browse/HADOOP-4226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yuri Pradkin updated HADOOP-4226:
---------------------------------
Status: Patch Available (was: In Progress)
Thanks for your input.
bq. TestTextInputFormat is testing LineRecordReader.LineReader, not
o.a.h.util.LineReader, to which this patch applies.
OK. BTW, are you planning to switch LRR to use util.LineReader?
bq. Why track str.getLength() with a local var?
Only as an optimization; for this little piece of code I think it's OK. It is
(or going to be) heavily used, as you say.
bq. This appears to regard \r as a valid character (newLineLength is reset for
each char read, and only relevant when followed by \n), but the original does
not.
Sorry, fixed. It was not obvious from looking at the code.
bq. If there isn't a unit test validating this, writing it would be helpful.
Done. Beating the hell out of it.
> LineReader::readLine cleanup
> ----------------------------
>
> Key: HADOOP-4226
> URL: https://issues.apache.org/jira/browse/HADOOP-4226
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Affects Versions: 0.19.0
> Reporter: Yuri Pradkin
> Assignee: Yuri Pradkin
> Priority: Minor
> Attachments: HADOOP-4226.patch, HADOOP-4226.patch, HADOOP-4226.patch,
> HADOOP-4226.patch
>
>
> I've been looking at HADOOP-4010 and realized that readLine is pretty
> convoluted. I changed the implementation which made it hopefully a little
> easier to read/validate/understand.
> I've had some problems testing it locally, so I'll submit it for Hudson to
> test.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
