[
https://issues.apache.org/jira/browse/HADOOP-3614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635052#action_12635052
]
Konstantin Shvachko commented on HADOOP-3614:
---------------------------------------------
# In {{FSDataset.updateBlock()}} you do not need to set
{{oldblock.setGenerationStamp(GenerationStamp.WILDCARD_STAMP)}}
# As far as I can see {{TestFileCtreation}} should be eventually moved to
{{org.apache.hadoop.hdfs.server.datanode}} pavkage in the test directory.
Because it uses mostly public (legally) classes and methods from other
packages, and some methods like getBlockFile() that were made public just to
keep the test in its current package. So I would rather leave findBlockFile()
public for now and wouldn't introduce new {{DataNodeTestUtil}} class.
# Please add a JavaDoc comment for findBlockFile() so that there were no
confusion about its semantics, which is rather hard to see right away.
> TestLeaseRecovery fails when run with assertions enabled.
> ---------------------------------------------------------
>
> Key: HADOOP-3614
> URL: https://issues.apache.org/jira/browse/HADOOP-3614
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.18.0
> Reporter: Konstantin Shvachko
> Fix For: 0.19.0
>
> Attachments: 3614_20080926.patch, 3614_20080926b.patch
>
>
> I used -ea jvm options to run the test, and it fails in
> FSDataset.findBlockFile(Block) on
> {code}
> assert b.generationStamp == GenerationStamp.WILDCARD_STAMP;
> {code}
> Without asserts on the test passes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
