[
https://issues.apache.org/jira/browse/HADOOP-4204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635858#action_12635858
]
Chris Douglas commented on HADOOP-4204:
---------------------------------------
{noformat}
+ Set<Entry<String, MetricValue>> entrySet = metricUpdates.entrySet();
+ for (Entry<String, MetricValue> entry : entrySet) {
+ String metricName = entry.getKey ();
+ MetricValue updateValue = entry.getValue ();
{noformat}
Formatting method invocations as {{ident ()}} is contrary to the [coding
conventions|http://java.sun.com/docs/codeconv/html/CodeConventions.doc7.html#490].
It is also more conventional to import java.util.Map (in every file you import
java.util.Map.Entry, java.util.Map is already imported) and use
{code}
for (Map.Entry<K,V> entry : map.entrySet()) {
// ...
}
{code}
It's not worth redoing the patch, but it's worth mentioning.
> Fix warnings generated by FindBugs
> ----------------------------------
>
> Key: HADOOP-4204
> URL: https://issues.apache.org/jira/browse/HADOOP-4204
> Project: Hadoop Core
> Issue Type: Bug
> Environment: This is compile time issue
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: HADOOP-4204.patch, HADOOP-4204.patch, HADOOP-4204.patch,
> HADOOP-4210.patch
>
>
> There are several warnings currently printed by findbugs. These need to be
> addressed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
