[
https://issues.apache.org/jira/browse/HADOOP-4287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638484#action_12638484
]
Vinod K V commented on HADOOP-4287:
-----------------------------------
The fix is fine. I have a few test-case related comments.
- You only have a test for failing maps, you should also have a test for
failing reduces.
- You should test for positive counts not just once, but through out the life
time of the job; so you need to check it in a loop till job completion.
Otherwise test-case success/failure would just be a matter of timing.
- I think you can rename the test-case to TestJobInProgess, because part of
which is what we are really testing here.
- Minor : You shouldn't catch and ignore any exception thrown by
RunningJob.runJob(). If something abnormal happens, let the test-case fail.
> [mapred] jobqueue_details.jsp shows negative count of running and waiting
> reduces with CapacityTaskScheduler.
> -------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4287
> URL: https://issues.apache.org/jira/browse/HADOOP-4287
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/capacity-sched
> Reporter: Vinod K V
> Assignee: Sreekanth Ramakrishnan
> Priority: Blocker
> Attachments: HADOOP-4287-1.patch, HADOOP-4287-2.patch
>
>
> This I observed while running a job that always fails because of reduce
> failures. Need to investigate this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
