[
https://issues.apache.org/jira/browse/HADOOP-4408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639308#action_12639308
]
Hadoop QA commented on HADOOP-4408:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12392054/4408-0.patch
against trunk revision 704261.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3454/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3454/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3454/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3454/console
This message is automatically generated.
> FsAction operations shouldn't create new Objects
> ------------------------------------------------
>
> Key: HADOOP-4408
> URL: https://issues.apache.org/jira/browse/HADOOP-4408
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.16.0
> Reporter: Chris Douglas
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: 4408-0.patch
>
>
> FsAction::and and related operations use {{values()[<expr>]}}, referencing a
> member var {{INDEX}}. This creates a new array object and uses member indices
> identical to {{ordinal()}}. It should either keep a reference to {{values()}}
> and use {{ordinal()}} explicitly or observe semantics consistent with
> {{INDEX}}.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
