[
https://issues.apache.org/jira/browse/HADOOP-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639371#action_12639371
]
Sharad Agarwal commented on HADOOP-4236:
----------------------------------------
test patch returned following:
[exec] -1 overall.
[exec] +1 @author. The patch does not contain any @author tags.
[exec] -1 tests included. The patch doesn't appear to include any new
or modified tests.
[exec] Please justify why no tests are needed for
this patch.
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec] -1 findbugs. The patch appears to introduce 1 new Findbugs
warnings.
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath
integrity.
Findbugs warning is :
<a href="#IS2_INCONSISTENT_SYNC">Bug type IS2_INCONSISTENT_SYNC (click for
details)</a>
<br/>In class org.apache.hadoop.mapred.JobInProgress<br/>Field
org.apache.hadoop.mapred.JobInProgress.initStarted<br/>Synchronized 50% of the
time<br/>Unsynchronized access at JobInProgress.java:[line
1980]<br/>Synchronized access at JobInProgress.java:[line 349]<br/>Synchronized
access at JobInProgress.java:[line 145]<br/>Synchronized access at
JobInProgress.java:[line 145]</p>
However initStarted is synchronized everywhere. Seems like findbugs is getting
confused.
> JobTracker.killJob() fails to kill a job if the job is not yet initialized
> --------------------------------------------------------------------------
>
> Key: HADOOP-4236
> URL: https://issues.apache.org/jira/browse/HADOOP-4236
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.19.0
> Reporter: Amar Kamat
> Assignee: Sharad Agarwal
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: 4236_v1.patch, 4236_v2.patch, 4236_v3.patch
>
>
> HADOOP-3864 made the following changes to {{JobTracker.killJob()}}
> {code}
> public synchronized void killJob(JobID jobid) {
> JobInProgress job = jobs.get(jobid);
> - job.kill();
> + if (job.inited()) {
> + job.kill();
> + }
> }
> {code}
> This is a bug as a job will not get killed if its not yet initialized.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
