[
https://issues.apache.org/jira/browse/HADOOP-4431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641001#action_12641001
]
Johan Oskarsson commented on HADOOP-4431:
-----------------------------------------
The patch looks good but I'm going to be picky, there are a few places in the
patch where the code style is a bit off. It's using tabs instead of two spaces
for indentation and { in the wrong places etc. Please see:
http://wiki.apache.org/hadoop/HowToContribute for more information.
Other then that it looks good. Could you please regenerate it and I'll commit
it. Is the patch to marked as an incompatible change?
> Add versionning/tags to Chukwa Chunk
> ------------------------------------
>
> Key: HADOOP-4431
> URL: https://issues.apache.org/jira/browse/HADOOP-4431
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/chukwa
> Reporter: Jerome Boulon
> Assignee: Jerome Boulon
> Attachments: HADOOP-4431.patch
>
>
> add tags field
> add version number to chunkImpl (contribute by Eric Y.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
