[ 
https://issues.apache.org/jira/browse/HADOOP-4454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641130#action_12641130
 ] 

Hadoop QA commented on HADOOP-4454:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12392400/comments_in_slaves.diff
  against trunk revision 706338.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3497/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3497/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3497/artifact/trunk/build/test/checkstyle-errors.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3497/console

This message is automatically generated.

> Support comments in 'slaves'  file
> ----------------------------------
>
>                 Key: HADOOP-4454
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4454
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: conf, scripts
>    Affects Versions: 0.17.2
>            Reporter: Rama, Ramasamy
>            Priority: Minor
>         Attachments: comments_in_slaves.diff
>
>
> Support comments in 'slaves'  file.
> Comments  start with '#' (start of line or inline )

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to