[
https://issues.apache.org/jira/browse/HADOOP-4369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641180#action_12641180
]
Tsz Wo (Nicholas), SZE commented on HADOOP-4369:
------------------------------------------------
{noformat}
[exec] -1 overall.
[exec] +1 @author. The patch does not contain any @author tags.
[exec] -1 tests included. The patch doesn't appear to include any new
or modified tests.
[exec] Please justify why no tests are needed for
this patch.
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec] +1 findbugs. The patch does not introduce any new Findbugs
warnings.
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath
integrity.
{noformat}
The change is simple. We don't need a new test here.
> Metric Averages are not averages
> --------------------------------
>
> Key: HADOOP-4369
> URL: https://issues.apache.org/jira/browse/HADOOP-4369
> Project: Hadoop Core
> Issue Type: Bug
> Components: metrics
> Affects Versions: 0.18.1
> Reporter: Brian Bockelman
> Priority: Blocker
> Fix For: 0.18.2
>
> Attachments: hadoop-4369.patch
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> Metrics averages are not averages; instead of updating the metric with the
> average number periodically, Hadoop metrics *increments* the metric.
> I.e., each update we have value = old_value + current average. Instead, we
> want each update to have value = current_average.
> Patch will be attached momentarily.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
