[
https://issues.apache.org/jira/browse/HADOOP-4467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641732#action_12641732
]
Chris K Wensel commented on HADOOP-4467:
----------------------------------------
via ant test-patch...
seems to be down on lack of tests. unsure, per previous comment, how to test
classloader issues.
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new
or modified tests.
[exec] Please justify why no tests are needed for
this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs
warnings.
[exec]
> SerializationFactory should use current context ClassLoader
> -----------------------------------------------------------
>
> Key: HADOOP-4467
> URL: https://issues.apache.org/jira/browse/HADOOP-4467
> Project: Hadoop Core
> Issue Type: Bug
> Affects Versions: 0.18.1, 0.19.0
> Reporter: Chris K Wensel
> Attachments: hadoop-4467-v2.patch, hadoop-4467.patch
>
>
> SerializationFactory#add calls Class.forName without a ClassLoader instance.
> This prevents user-space Serialization classes from being loaded.
> The resulting ClassNotFoundException is eaten after being logged, and a NPE
> is thrown further down the line when a Serializer is requested.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
