[ 
https://issues.apache.org/jira/browse/HADOOP-4141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12643801#action_12643801
 ] 

Hadoop QA commented on HADOOP-4141:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12393038/HADOOP-4141.patch.3
  against trunk revision 709040.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 2 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3510/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3510/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3510/artifact/trunk/build/test/checkstyle-errors.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3510/console

This message is automatically generated.

> ScriptBasedMapping has infinite loop with invalid jobconf parameter
> -------------------------------------------------------------------
>
>                 Key: HADOOP-4141
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4141
>             Project: Hadoop Core
>          Issue Type: Bug
>    Affects Versions: 0.18.1
>            Reporter: Aaron Kimball
>            Priority: Minor
>         Attachments: HADOOP-4141.patch.3, scriptMap.patch, scriptMap.patch.2, 
> TestScriptBasedMapping.java
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> A few bugs in ScriptBasedTopology:
> 1) topology.script.number.args is not validated; if this is <= 0, the 
> runResolveCommand() method will run its outer loop an infinite number of 
> times. 
> 2) CachedDNSToSwitchMapping assumes that if a List is returned, it has the 
> same cardinality as the number of names. ScriptBasedMapping should return 
> 'null' instead of a mis-sized list on error

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to