[
https://issues.apache.org/jira/browse/HADOOP-3461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12644466#action_12644466
]
Tsz Wo (Nicholas), SZE commented on HADOOP-3461:
------------------------------------------------
{noformat}
[exec] -1 overall.
[exec] +1 @author. The patch does not contain any @author tags.
[exec] -1 tests included. The patch doesn't appear to include any new
or modified tests.
[exec] Please justify why no tests are needed for
this patch.
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec] +1 findbugs. The patch does not introduce any new Findbugs
warnings.
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath
integrity.
{noformat}
All unit tests are passed locally.
> Remove dfs.StringBytesWritbale
> ------------------------------
>
> Key: HADOOP-3461
> URL: https://issues.apache.org/jira/browse/HADOOP-3461
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 3461_20081030.patch
>
>
> In dfs, some classes, such as INodeFileUnderConstruction use,
> StringBytesWritbale as member type. The values are converted from String to
> StringBytesWritbale in setter and converted back to String in getter. These
> overhead is unnecessary.
> StringBytesWritbale is not used in RPC nor dfs image. No version change will
> be introduced.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
