[
https://issues.apache.org/jira/browse/HADOOP-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645161#action_12645161
]
Hadoop QA commented on HADOOP-4572:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12393273/4572_20081103.patch
against trunk revision 711482.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 24 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3531/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3531/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3531/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3531/console
This message is automatically generated.
> INode and its sub-classes should be package private
> ---------------------------------------------------
>
> Key: HADOOP-4572
> URL: https://issues.apache.org/jira/browse/HADOOP-4572
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 4572_20081103.patch
>
>
> INode, INodeFile, INodeDirectory and INodeFileUnderConstruction should be
> changed from public to package private. As a consequence, some test classes
> like CreateEditsLog have to be moved to
> org.apache.hadoop.hdfs.server.namenode.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
