[
https://issues.apache.org/jira/browse/HADOOP-4583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Suresh Srinivas updated HADOOP-4583:
------------------------------------
Attachment: 4583.patch
New patch uploaded. Here are the results of testing the patch. No tests
included as the functionality is tested by existing tests.
[exec] -1 overall.
[exec] +1 @author. The patch does not contain any @author tags.
[exec] -1 tests included. The patch doesn't appear to include any new
or modified tests.
[exec] Please justify why no tests are needed for
this patch.
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec] +1 findbugs. The patch does not introduce any new Findbugs
warnings.
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath
integrity.
> Code optimization/cleanup in HDFS
> ---------------------------------
>
> Key: HADOOP-4583
> URL: https://issues.apache.org/jira/browse/HADOOP-4583
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.20.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.20.0
>
> Attachments: 4583.patch, 4583.patch
>
>
> Some of the changes needed:
> - FSNameSystem.allocateBlock creates a lot of object unnecessarily to find a
> blockID that is unused. It should reuse the Block object created by changing
> the blockID and reusing the GenerationStamp.
> - InodeFile.addBlock should use System.arrayCopy instead of copying 1 at a
> time.
> - Some of the for loops in FSEditLog.java can be optimized. Instead of
> getting the edit stream length in termination condition, a local variable
> should be used to do the same.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
