[ 
https://issues.apache.org/jira/browse/HADOOP-4185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12646732#action_12646732
 ] 

Doug Cutting commented on HADOOP-4185:
--------------------------------------

> how about putting it to a new interface, say Checksumable

If any FileSystem might implement this interface then I don't see how this is 
functionally different than adding this to FileSystem.java.  It just adds ugly 
code whenever you call setVerifyChecksum.  Casting and 'instanceof' are 
indications of poor object modeling.  Sometimes they're required, but we 
shouldn't use them except as a last resort.


> Add setVerifyChecksum() method to FileSystem
> --------------------------------------------
>
>                 Key: HADOOP-4185
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4185
>             Project: Hadoop Core
>          Issue Type: Sub-task
>          Components: fs
>            Reporter: Tom White
>            Assignee: Sharad Agarwal
>         Attachments: 4185_v1.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to