[ 
https://issues.apache.org/jira/browse/HADOOP-4471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12647262#action_12647262
 ] 

Hemanth Yamijala commented on HADOOP-4471:
------------------------------------------

Based on the discussions above, we are deciding to go ahead with this fix. I 
have checked verified the patch applies still to trunk, and here are the latest 
test-patch results:

     [exec] +1 overall.

     [exec]     +1 @author.  The patch does not contain any @author tags.

     [exec]     +1 tests included.  The patch appears to include 3 new or 
modified tests.

     [exec]     +1 javadoc.  The javadoc tool did not generate any warning 
messages.

     [exec]     +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.

     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs 
warnings.

     [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath 
integrity.

Capacity scheduler tests pass with this patch. No other components should be 
affected.

> Capacity Scheduler should maintain the right ordering of jobs in its running 
> queue
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-4471
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4471
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/capacity-sched
>    Affects Versions: 0.19.0
>            Reporter: Vivek Ratan
>            Assignee: Sreekanth Ramakrishnan
>            Priority: Blocker
>             Fix For: 0.19.1
>
>         Attachments: HADOOP-4471-v1.patch
>
>
> Currently, the Capacity Scheduler maintains a simple linked list of jobs 
> which are running. This implies that running jobs are sorted by when they 
> started running (i.e., when they were added to the queue). The Scheduler 
> should maintain the same ordering among running jobs that it does for waiting 
> jobs. Jobs should be sorted by priority (if the queue supports priorities) 
> and by their submit time. 
> This sorting would be more fair in deciding which running jobs get access to 
> a free TT. It also does not penalize jobs that have a longer setup task, 
> which affects when they enter the run queue. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to