[
https://issues.apache.org/jira/browse/HADOOP-3422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12648700#action_12648700
]
stack commented on HADOOP-3422:
-------------------------------
Couple of nitpicks: Use StringBuilder instead of StringBuffer and the set of
StringBuffer length to zero on line #47 is not needed since you just created a
new instance. Also, make comment on line #45 < 80 characters. Otherwise, I
tried the patch against 0.19.0. All works.
What you think we should do about rpc and jvm 'record' names? They both use
'metrics'. Its kinda useless. Means all rpc and jvm metrics get lumped
together. Other metrics records are better named: e.g. 'datanode', 'namenode',
etc. Should we fix this as part of this patch or in a new issue?
The jvm metrics record might be named for the application its hosting. And rpc
the same?
> Ganglia counter metrics are all reported with the metric name "value", so the
> counter values can not be seen
> ------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-3422
> URL: https://issues.apache.org/jira/browse/HADOOP-3422
> Project: Hadoop Core
> Issue Type: Bug
> Components: metrics
> Affects Versions: 0.17.2, 0.18.0, 0.18.1, 0.18.2
> Reporter: Jason
> Fix For: hudson, 0.19.1, 0.20.0
>
> Attachments: diff-20080520-1025.txt,
> ganglia-patch-3422-and-4137.patch, ganglia-patch-3422-and-4137.patch,
> ganglia-patch-3422-qand-4137-1.patch, ganglia-patch-3422-updated.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The JobInProgress class reports all metrics with the name "value". The
> FileMetrics class puts all of the tags into the name when reporting the
> individual values, but the Ganglia Context does not put the tags into the
> name..
> This patch modifies the context to build names for the counter metrics out of
> the tag values. This enables the user to see the indivdual counter values
> with the ganglia web tool, on a per job basis
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
