[
https://issues.apache.org/jira/browse/HADOOP-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12649902#action_12649902
]
Hadoop QA commented on HADOOP-4579:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12393343/hadoop4579.patch
against trunk revision 719787.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3627/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3627/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3627/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3627/console
This message is automatically generated.
> StorageDirectory is not removed from the storage directories list when
> writing to an edits fails
> ------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4579
> URL: https://issues.apache.org/jira/browse/HADOOP-4579
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Fix For: 0.20.0
>
> Attachments: hadoop4579.patch
>
>
> If there is an IO Error on any log operations the directory should be removed
> from the list of active storage directories.
> when it happens function FSEditLog:processIOError() is called.
> in this function:
> ....
> File parentStorageDir =
> ((EditLogFileOutputStream)editStreams.get(index)).getFile().getParentFile().getParentFile();
> -- which returns root
> ....
> fsimage.processIOErrors(parentStorageDir);
> ...
> which calles FSImage:ProcessIOErrors(dir).
> but when dir is compared against list of storage dirs getParent is used
> instead of getPath()
> so the match is never found.
> ....
> if (sd.getRoot().getPath().equals(dirName.getParent())) {
> - should be dirName.getPath()
> .....
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
