[
https://issues.apache.org/jira/browse/HADOOP-4649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652273#action_12652273
]
Jothi Padmanabhan commented on HADOOP-4649:
-------------------------------------------
Currently, the IFile*Streams do exactly what you want for SpillRecords - namely
create/validate a checksum at the end of the file. So, to avoid duplication of
code, we could just use them here.
If at a later stage, if we find that the CRC algorithm for IFIle is affecting
the performance for SpillRecord or we change these streams when modifying the
IFile layout, we could revisit this, no?
I am fine with the existing patch but would like to avoid duplication of the
code, if we could. I am +1 otherwise.
> Improve abstraction for spill indices
> -------------------------------------
>
> Key: HADOOP-4649
> URL: https://issues.apache.org/jira/browse/HADOOP-4649
> Project: Hadoop Core
> Issue Type: Improvement
> Reporter: Chris Douglas
> Assignee: Chris Douglas
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: 4649-0.patch, 4649-1.patch, 4649-2.patch
>
>
> In support of changing checksum handling as part of the migration to Jetty6,
> some of the spill code would be easier to reason about with a different
> abstraction.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
