[ 
https://issues.apache.org/jira/browse/HADOOP-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Douglas updated HADOOP-4796:
----------------------------------

        Fix Version/s: 0.20.0
    Affects Version/s: 0.20.0
               Status: Open  (was: Patch Available)

The patch looks good, but the following should be omitted:
{noformat}
+              <!-- FIXME: Fix incompleted test cases -->
+              <exclude name="**/TestDemux.java"/>
+              <exclude name="**/TestAgentCollector.java"/>
+              <exclude name="**/TestChukwaAppender.java"/>
{noformat}

Assuming the tests themselves are invalid, they should be removed from the 
distribution and added back in a separate issue once they're fixed. Removing 
them as part of this patch would make sense.

> Test target for chukwa build.xml needs to comply to hadoop build.xml test 
> suites
> --------------------------------------------------------------------------------
>
>                 Key: HADOOP-4796
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4796
>             Project: Hadoop Core
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>         Environment: Redhat EL 5, Java 6
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>             Fix For: 0.20.0
>
>         Attachments: HADOOP-4796.diff
>
>
> Chukwa build.xml file is not honoring the hadoop test target.  When calling 
> ant -Dtest.include=mapred/Test* test, this command also executes chukwa test 
> cases.  The build.xml needs to be polished to avoid testing the wrong test 
> cases.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to