[
https://issues.apache.org/jira/browse/HADOOP-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654350#action_12654350
]
Hadoop QA commented on HADOOP-4757:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12395204/log4j_xml_config_v2.patch
against trunk revision 724229.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3685/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3685/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3685/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3685/console
This message is automatically generated.
> Replace log4j.properties with log4j.xml
> ---------------------------------------
>
> Key: HADOOP-4757
> URL: https://issues.apache.org/jira/browse/HADOOP-4757
> Project: Hadoop Core
> Issue Type: Improvement
> Reporter: Alex Loddengaard
> Assignee: Alex Loddengaard
> Priority: Minor
> Attachments: log4j_xml_config.patch, log4j_xml_config_v2.patch
>
>
> Certain log4j features are not configurable via the log4j.properties file,
> not to mention the log4j.properties file is messy. For this reason, we
> should transition to a XML file to configure log4j. The .properties vs. .xml
> argument has only come up in HADOOP-211, where the XML configuration was
> vetoed for Tomcat integration issues.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
