[
https://issues.apache.org/jira/browse/HADOOP-4771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654724#action_12654724
]
Hadoop QA commented on HADOOP-4771:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12395371/hadoop-4771-v2.patch
against trunk revision 724578.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3692/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3692/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3692/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3692/console
This message is automatically generated.
> FSImage saveFSImage() will have problem.
> ----------------------------------------
>
> Key: HADOOP-4771
> URL: https://issues.apache.org/jira/browse/HADOOP-4771
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.19.0, 0.19.1, 0.20.0
> Reporter: Ruyue Ma
> Assignee: Ruyue Ma
> Fix For: 0.19.1, 0.20.0
>
> Attachments: hadoop-4771-v2.patch, hadoop-4771.patch
>
>
> When you format the namenode , hadoop will call FSImage.saveFsImage().
> saveFsImage includes the following code:
> out.writeLong(fsDir.rootDir.numItemsInTree());
> When format, the fsDir.rootDir.numItemsInTree() should be 1 (it include the
> rootdir). But now fsDir.rootDir.numItemsInTree() is 0.
> The reason why the bug is not simply discovered or triggered is the code in
> FSImage.saveFsImage().->saveINode2Image().
> } else { // write directory inode
> out.writeShort(0); // replication
> Because the directory doesn't have replication factor, so here is 0. This
> will cause loadFilesUnderConstruction() will not load any files when hadoop
> fisrt starts up after format.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
