[
https://issues.apache.org/jira/browse/HADOOP-4706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12655492#action_12655492
]
Hadoop QA commented on HADOOP-4706:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12395544/hadoop-4706-v1.patch
against trunk revision 725507.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3704/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3704/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3704/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3704/console
This message is automatically generated.
> IFileOutputStream.close should call close of the underlying stream
> ------------------------------------------------------------------
>
> Key: HADOOP-4706
> URL: https://issues.apache.org/jira/browse/HADOOP-4706
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.19.0
> Reporter: Jothi Padmanabhan
> Assignee: Jothi Padmanabhan
> Priority: Minor
> Attachments: hadoop-4706-v1.patch, hadoop-4706.patch
>
>
> Currently the IFileOutputStream.close just creates the checksum of the data
> written, but does not call the close of the underlying stream. Ideally the
> checksum calculation should be handled in a different finish() function and
> the close should close the underlying stream
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
