[ 
https://issues.apache.org/jira/browse/HADOOP-4860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656095#action_12656095
 ] 

Eric Yang commented on HADOOP-4860:
-----------------------------------

{noformat}
     [exec] +1 overall.  

     [exec]     +1 @author.  The patch does not contain any @author tags.

     [exec]     +1 tests included.  The patch appears to include 9 new or 
modified tests.

     [exec]     +1 javadoc.  The javadoc tool did not generate any warning 
messages.

     [exec]     +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.

     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs 
warnings.

     [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath 
integrity.
{noformat}

> File Tailing Adaptor test cases causes random failure
> -----------------------------------------------------
>
>                 Key: HADOOP-4860
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4860
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/chukwa
>         Environment: RedHat 4.5, Java 6
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>         Attachments: HADOOP-4860.patch
>
>
> TestFileTailingAdaptors contain code to startup and shut down Chukwa Agent 3 
> times.  In each of the startup, ChukwaAgent will attempt to restore to its 
> state to where it was previously sending data.  This means the data in 
> transit may not be the data that the test case is expecting, and test case 
> fails.  The test cases should be divided into 3 different Test classes, the 
> automated test framework will remove chukwa check point file to prevent the 
> previous  state to interfere with the current test cases.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to