[
https://issues.apache.org/jira/browse/HADOOP-4904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tsz Wo (Nicholas), SZE updated HADOOP-4904:
-------------------------------------------
Hadoop Flags: [Reviewed]
+1 patch looks good.
{noformat}
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new
or modified tests.
[exec] Please justify why no tests are needed for
this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs
warnings.
[exec]
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath
integrity.
{noformat}
> Deadlock while leaving safe mode.
> ---------------------------------
>
> Key: HADOOP-4904
> URL: https://issues.apache.org/jira/browse/HADOOP-4904
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.18.3
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Priority: Blocker
> Fix For: 0.18.3
>
> Attachments: safeModeDeadlock-0-18.patch,
> safeModeDeadlock-0-18.patch, safeModeDeadlock.patch
>
>
> {{SafeModeInfo.leave()}} acquires locks in an incorrect order, which causes
> the deadlock.
> It first acquires the {{SafeModeInfo}} lock, then calls
> {{FSNamesystem.processMisReplicatedBlocks()}}, which requires the global
> {{FSNamesystem}} lock.
> It should be the other way around: first {{FSNamesystem}} lock, then
> {{SafeModeInfo}}.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
