[ 
https://issues.apache.org/jira/browse/HADOOP-4779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12658928#action_12658928
 ] 

Tsz Wo (Nicholas), SZE commented on HADOOP-4779:
------------------------------------------------

{noformat}
     [exec] -1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     +1 tests included.  The patch appears to include 18 new or 
modified tests.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning 
messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
     [exec] 
     [exec]     -1 findbugs.  The patch appears to cause Findbugs to fail.
     [exec] 
     [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath 
integrity.
{noformat}

The detail findbugs report (newPatchFindbugsWarnings.html) does not contain any 
warning.  I suspect the test-patch script does not work correctly in this patch.

> Remove deprecated FileSystem methods
> ------------------------------------
>
>                 Key: HADOOP-4779
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4779
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: fs
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: 4779_20081204.patch, 4779_20081218.patch
>
>
> Deprecated FileSystem methods like getReplication(Path src), delete(Path f), 
> etc. should be removed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to