[
https://issues.apache.org/jira/browse/HADOOP-4268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659158#action_12659158
]
Konstantin Shvachko commented on HADOOP-4268:
---------------------------------------------
# NamenodeFsck constructor has new parameters, which can be obtained from the
{{NameNode nn}} parameter during the construction. Why do you need the new
parameters?
# I do not understand the reason for factoring out {{TestDFSck}} into a
separate class especially if it is in a separate package.
I would rather place both methods from {{TestDFSck}} back into {{TestFsck}}.
# I don't think introduction of a new package is justified in the case.
# In any case {{TestDFSck}}, {{runDFSck}} anything with DFS are bad names, we
should use HDFS or nothing.
# {{testPermission()}} should have a Javadoc explaining what the test tests and
how.
So that one could see it from the description without going through the code.
> Permission checking in fsck
> ---------------------------
>
> Key: HADOOP-4268
> URL: https://issues.apache.org/jira/browse/HADOOP-4268
> Project: Hadoop Core
> Issue Type: New Feature
> Components: dfs
> Affects Versions: 0.17.2
> Reporter: Koji Noguchi
> Attachments: 4268_20081217.patch, 4268_20081218.patch,
> 4268_20081218b.patch
>
>
> Quoting from HADOOP-3222 ("fsck should require superuser privilege"),
> bq. I agree that it makes sense to make fsck do permission checking for the
> nodes that it traverses. If a user does a fsck on files/directories that
> he/she has access to (using permissions) then that invocation of fsck should
> be allowed. Since "/" is usually owned by super-user, only super-user should
> be allowed to run fsck on "/".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
