[
https://issues.apache.org/jira/browse/HADOOP-4935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659938#action_12659938
]
Tsz Wo (Nicholas), SZE commented on HADOOP-4935:
------------------------------------------------
ant test-patch results:
{noformat}
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new
or modified tests.
[exec] Please justify why no tests are needed for
this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs
warnings.
[exec]
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath
integrity.
{noformat}
> Manual leaving of safe mode may lead to data lost
> -------------------------------------------------
>
> Key: HADOOP-4935
> URL: https://issues.apache.org/jira/browse/HADOOP-4935
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.18.3
> Reporter: Hairong Kuang
> Assignee: Konstantin Shvachko
> Fix For: 0.18.3
>
> Attachments: misReplBlocks-0-18.patch, misReplBlocks.patch
>
>
> Due to HADOOP-4610, NameNode calculates mis-replicated blocks when leaving
> safe mode manually, where it clears the pending deletion queue before it does
> the calculation. This works fine when NameNode just starts but introduced a
> bug when NameNode is running for a while. Clearing the pending deletion queue
> makes NameNode not able to distinguish valid replicas from invalid ones, ie,
> the ones that have scheduled or dispatched for deletion. Therefore, NameNode
> may mistakenly decide the block is over-replicated and choose all valid ones
> to delete.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
